Skip to content

[Veeam] Fix full backup VM restore exception#5680

Merged
DaanHoogland merged 1 commit intoapache:mainfrom
scclouds:veeam-fix-full-vm-restore-from-backup-exception
Dec 10, 2021
Merged

[Veeam] Fix full backup VM restore exception#5680
DaanHoogland merged 1 commit intoapache:mainfrom
scclouds:veeam-fix-full-vm-restore-from-backup-exception

Conversation

@SadiJr
Copy link
Copy Markdown
Contributor

@SadiJr SadiJr commented Nov 11, 2021

Description

Using the VMWare hypervisor, and with Veeam integration enabled, a full restore of a VM using a backup in Veeam occurs correctly, but in ACS an exception is thrown: Restore VM Backup (607c2bbf-2c23-49a1-9549-cd402441dcb5) Error during vm backup restore and import: Invalid string format

Upon adding more logs to the restore process, it was discovered that this was because the VM being restored had no value in the hostid attribute.

This PR fixes this behavior, increments the logs in the restore process for VMs using backups and adds new unit tests.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

It was tested in a local laboratory:

  1. I have assigned one VM to a Backup Offering;
  2. I backed up the VM manually;
  3. I tried to perform a full VM restore using this backup;
  4. Before, there was an exception in ACS, now the restore finishes without problems.

Copy link
Copy Markdown
Contributor

@GutoVeronezi GutoVeronezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLTGM

@sureshanaparti
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1790

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan test centos7 vmware-67u3

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-2607)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34309 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5680-t2607-vmware-67u3.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good and integration suite passes. I have no way of testing this (easily) so I'll trust actual users of the veeam plugin to shout if any reason.

@DaanHoogland
Copy link
Copy Markdown
Contributor

btw @SadiJr do you want this on 4.17 or 4.16.1? as it is a bug fix you may want to rebase, so it gets in 4.16.1 first.

@SadiJr
Copy link
Copy Markdown
Contributor Author

SadiJr commented Dec 9, 2021

@DaanHoogland

Sorry for the delay in answer. For me, there's no problem in make this changes in 4.17.

@DaanHoogland DaanHoogland added this to the 4.17.0.0 milestone Dec 10, 2021
@DaanHoogland DaanHoogland merged commit 9363f64 into apache:main Dec 10, 2021
mlsorensen pushed a commit to mlsorensen/cloudstack that referenced this pull request Dec 20, 2021
Co-authored-by: SadiJr <sadi@scclouds.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants